Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented tracing configs #927

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

denniskniep
Copy link

Summary

Implements the tracing configs in the Pomerium CRD

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@denniskniep denniskniep requested a review from a team as a code owner March 27, 2024 20:37
@denniskniep denniskniep requested review from calebdoxsey and removed request for a team March 27, 2024 20:37
@CLAassistant
Copy link

CLAassistant commented Mar 27, 2024

CLA assistant check
All committers have signed the CLA.

@wasaga
Copy link
Collaborator

wasaga commented Mar 27, 2024

my preference would be to keep CRD structured rather then a flat list of parameters, similar to other options:

tracing:
  datadog:
    address: xxxxxxx

or

tracing:
  jaeger:
    collectorEndpoint: xxxx

and

  • implicitly setting the provider based on which key is used
  • adding a validation rule that two providers may not be defined simultaneously

imagine in future we would have OTEL export for example that may have a whole bunch of parameters and it would be nice to group them somewhere under

tracing:
  otel:

this spec is used to auto-generate reference documentation with topmost level keys becoming sections: https://www.pomerium.com/docs/deploying/k8s/reference

@calebdoxsey calebdoxsey requested review from wasaga and removed request for calebdoxsey March 28, 2024 16:18
@eadwu
Copy link

eadwu commented Sep 30, 2024

Is it still not possible to configure tracing with Pomerium using this? It seems like setting it via environment variables doesn't work either (i.e. TRACING_PROVIDER).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants