Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prometheus Resources as Kustomize Component #800

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haggishunk
Copy link

Summary

Adds support for prometheus resources to be composed into a pomerium deployment using the kustomize components feature.

Background

The current resources can be composed as kustomize resources

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- https://github.com/pomerium/ingress-controller.git/config/default?ref=v0.23.0
- https://github.com/pomerium/ingress-controller.git/config/prometheus?ref=v0.23.0

However flux kustomizations only support one path which requires users to deploy two such objects.

Also, some users prefer not to use remote kustomize bases.

Use Cases

Kustomize local or remote bases:

apiVersion: kustomize.config.k8s.io/v1beta1
kind: Kustomization
resources:
- https://github.com/pomerium/ingress-controller.git/config/default?ref=<newtag>
components:
- https://github.com/pomerium/ingress-controller.git/config/components/prometheus?ref=<newtag>

Flux kustomization:

apiVersion: source.toolkit.fluxcd.io/v1
kind: GitRepository
metadata:
  name: pomerium-ingress-controller
spec:
  ref:
    tag: <newtag>
  url: https://github.com/pomerium/ingress-controller.git
---
apiVersion: kustomize.toolkit.fluxcd.io/v1beta2
kind: Kustomization
metadata:
  name: pomerium-ingress-controller
spec:
  sourceRef:
    kind: GitRepository
    name: pomerium-ingress-controller
  path: config/default
  components:
  - ../components/prometheus

Checklist

  • reference any related issues
  • updated docs
  • updated unit tests
  • updated UPGRADING.md
  • add appropriate tag (improvement / bug / etc)
  • ready for review

@haggishunk haggishunk requested a review from a team as a code owner November 5, 2023 20:26
@haggishunk haggishunk requested review from wasaga and removed request for a team November 5, 2023 20:26
@CLAassistant
Copy link

CLAassistant commented Nov 5, 2023

CLA assistant check
All committers have signed the CLA.

@haggishunk
Copy link
Author

Hi @wasaga would you be kind enough to review this PR please?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants