Do not assume the kubernetes cluster domain #401
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adding the suffix "cluster.local" in the service domain breaks compatibility with k8s clusters with custom domains. Just defining until ".svc" will use the "search" in /etc/resolv.conf to complete the domain with the correct value.
|
Hi @adrianlzt thanks for the PR! Looking at https://github.com/kubernetes/dns/blob/master/docs/specification.md I cannot see that would you mind opening an Issue (linking to that PR) and describe your setup, so that we could better understand the custom domain / multi-zone support and solicit feedback from the community. |
wasaga
added
NeedsInvestigation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Adding the suffix "cluster.local" in the service domain breaks compatibility with k8s clusters with custom domains.
Just defining until ".svc" will use the "search" in /etc/resolv.conf to complete the domain with the correct value.
Checklist
improvement/bug/ etc)