Merge pull request #2 from polyphony-chat/clone-and-partialeq

Clone and partialeq

Cargo.toml

@@ -1,7 +1,7 @@
 [package]
 name = "pubserve"
 license = "MPL-2.0"
-version = "1.1.0-alpha.1"
+version = "1.1.0"
 edition = "2021"
 authors = ["bitfl0wer <[email protected]>"]
 description = "Simple, generic observer trait."

src/lib.rs

@@ -56,6 +56,7 @@ pub trait Subscriber<T> {
 /// let mut publisher = Publisher::<String>::new();
 /// publisher.publish("Hello, World!".to_string()); // .await, if async feature is enabled
 /// ```
+#[derive(Clone)]
 pub struct Publisher<T> {
     subscribers: Vec<ReferenceCounted<dyn Subscriber<T>>>,
 }
@@ -68,6 +69,19 @@ impl<T> Debug for Publisher<T> {
     }
 }
 
+impl<T> PartialEq for Publisher<T> {
+    fn eq(&self, other: &Self) -> bool {
+        for (own_subscriber, other_subscriber) in
+            self.subscribers.iter().zip(other.subscribers.iter())
+        {
+            if !ReferenceCounted::ptr_eq(own_subscriber, other_subscriber) {
+                return false;
+            }
+        }
+        true
+    }
+}
+
 impl<T> std::default::Default for Publisher<T> {
     fn default() -> Self {
         Self {

tests/clone.rs

@@ -0,0 +1,36 @@
+// This Source Code Form is subject to the terms of the Mozilla Public
+// License, v. 2.0. If a copy of the MPL was not distributed with this
+// file, You can obtain one at https://mozilla.org/MPL/2.0/.
+
+#[cfg(not(feature = "async"))]
+#[test]
+fn test_clone() {
+    use std::cell::RefCell;
+
+    use pubserve::{Publisher, ReferenceCounted, Subscriber};
+
+    struct MySubscriber {
+        vec: RefCell<Vec<i32>>,
+    }
+
+    impl Subscriber<i32> for MySubscriber {
+        fn update(&self, message: &i32) {
+            self.vec.borrow_mut().push(*message);
+            dbg!(self.vec.borrow());
+        }
+    }
+
+    let mut publisher = Publisher::<i32>::new();
+    let shared = ReferenceCounted::new(MySubscriber {
+        vec: RefCell::new(Vec::new()),
+    });
+    publisher.subscribe(shared.clone());
+    publisher.publish(42);
+    assert!(shared.vec.borrow().contains(&42));
+    // Test, if cloning the publisher, then dropping the original publisher, still allows the
+    // subscriber to receive messages.
+    let publisher_clone = publisher.clone();
+    drop(publisher);
+    publisher_clone.publish(43);
+    assert!(shared.vec.borrow().contains(&43));
+}