fix: ci failure #20
fix: ci failure #20
Conversation
There was a problem hiding this comment.
Great stuff, thanks for fixing this. The CI should have been automated to run on pull_request all along.
Historically it has been a pain to maintain the CI and through different versions of JDK and Gradle stuff seems to break, new build systems get added over time (ninja).
The previous CI was setup to forcibly use an older version of JDK because that caused a crash when building it and was a known issue at the time, with the only work around was to roll back.
I previously had a macOS CI as well but that too became difficult to maintain and keep up with. The whole thing works more easily on a local machine if you install Android Studio it kind of just works but is a bit more tricky configuring a runner!
.github/workflows/main.yml
Outdated
| - name: Setup Android SDK | ||
| uses: android-actions/setup-android@v2 | ||
|
|
||
| #- name: Setup Android SDK |
There was a problem hiding this comment.
you can remove this commented code if it is no longer required
… android sdk pre-installed.
|
Thank you very much! :) |
Hopefully it will fix the ci failure due to issues with newer versions of gradle.