fix navigator error (alternative to #30) #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to the proposed change of PR #30. This PR is NOT intended to downvote #30. Just an alternative.
Problem summary
dev server fails during SSR because server-side code calls navigator, which doesn’t exist in Node. The stack shows the call originates in src/store/index.ts -> detectDevice, causing 500 errors for page and favicon requests.
Fix
Edit src/store/index.ts to avoid accessing navigator during SSR. Replace direct navigator usage with a safe browser check using SvelteKit’s browser flag or a typeof check.