Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: qr-code #801

Merged
merged 2 commits into from
Aug 1, 2024
Merged

fix: qr-code #801

merged 2 commits into from
Aug 1, 2024

Conversation

ryanleecode
Copy link
Contributor

@ryanleecode ryanleecode commented Jul 31, 2024

@ryanleecode ryanleecode changed the title [DNM] fix: qr-code fix: qr-code Jul 31, 2024
@ryanleecode ryanleecode requested review from TarikGul and bee344 July 31, 2024 23:51
@ryanleecode ryanleecode marked this pull request as ready for review July 31, 2024 23:52
Copy link
Member

@TarikGul TarikGul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one nit - Once that is resolved we can merge this in and I'll do a release.

Amazing job 👍

@TarikGul TarikGul merged commit 3c890a3 into master Aug 1, 2024
3 checks passed
@TarikGul TarikGul deleted the fix/qr-code branch August 1, 2024 00:11
@polkadot-js-bot
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@polkadot-js polkadot-js locked as resolved and limited conversation to collaborators Aug 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Signing transactions with polkadot vault not working in firefox
3 participants