fix: extension does not get injected on page load

[tien]

Resolves #1475

[tien]

This is similar to how Talisman Wallet does injection: https://github.com/TalismanSociety/talisman/blob/6b49bf846bc5934f70e20e72e8fcaf5ac2c3343a/apps/extension/src/page.ts#L53

[TarikGul]

The promise needs to be handled:

inject();
redirectIfPhishing().catch((e) => console.warn(`Unable to determine if the site is in the phishing list: ${(e as Error).message}`));

could work?

[TarikGul]

Needs to be linted: yarn lint, and the promise needs to be handled.

[TarikGul]

I just need to look into this more, I am not sure of the side affects - like what is the consequences of injecting before a redirect is established? It would nullify the return value (boolean) of the redirect

[tien]

I don't think it matter if a redirect happens. Because the user will no longer be on that page anyway.

[Tbaut]

This looks ok to me, as redirecting would still be quick enough for users not to have time to interact with the website, but in 99.9% of the cases, when there's no redirect, it will save the time it takes to call the phishing api which was delaying the injection.

[TarikGul]

Yea did some looking into the actual call stack happening, and I don't think there is any residual issues happening! Going to add this to the release that I cut today

[polkadot-js-bot]

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.