RFC: Bridge ID for Ethereum Networks #49
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acatangiu
approved these changes
Apr 2, 2024
|
|
||
| This changes the ABI of the `NetworkId` type and all types that rely on it. As such, it is breaking change that will require storage upgrades and so on. | ||
|
|
||
| So we should include it in XCMv4, if accepted |
There was a problem hiding this comment.
Suggested change
| So we should include it in XCMv4, if accepted | |
| So we should include it in XCMv5, if accepted |
| Authors: | ||
| - Vincent Geddes | ||
| Created: 2023-11-16 | ||
| Impact: Trivial |
There was a problem hiding this comment.
Suggested change
| Impact: Trivial | |
| Impact: High |
Maybe even Breaking since it's breaking the existing NetworkId::Ethereum encoding and requires migrations.
|
@vgeddes this looks good to me, please mark it ready for review (after doing any cleanup you see fit) @paritytech/xcm ptal |
|
|
||
| ## Motivation | ||
|
|
||
| As a convention, assets in foreign consensus systems are generally identified using locations of the form |
There was a problem hiding this comment.
Suggested change
| As a convention, assets in foreign consensus systems are generally identified using locations of the form | |
| As a convention, assets in foreign consensus systems are generally identified using absolute locations of the form |
| } | ||
| ``` | ||
|
|
||
| For example, in the context of a the Polkadot network, a smart contract on Ethereum can be identified using this location: |
There was a problem hiding this comment.
Suggested change
| For example, in the context of a the Polkadot network, a smart contract on Ethereum can be identified using this location: | |
| For example, in the context of the Polkadot network, a smart contract on Ethereum can be identified using this absolute location: |
|
|
||
| ## Specification | ||
|
|
||
| Apply the following changes in XCMv4: |
There was a problem hiding this comment.
Suggested change
| Apply the following changes in XCMv4: | |
| Apply the following changes in XCMv5: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identical assets from foreign networks at the global level are not necessarily fungible with each other. This is because said assets could be exported to Polkadot through the use of different bridges.
This is a continuation of the discussion in #33 (I changed my mind on the conclusion of that discussion).
This is still a draft - need to clean it up a bit. But am still keen to receive early feedback.