refactor(json-rpc): remove while loop from getSmProvider
#621
+25
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tien
force-pushed
the
refactor/remove-while-loop-from-sm-provider
branch
2 times, most recently
from
a1941d6
to
041d84e
Compare
|
Oops, I think the test e2e test is stuck because it's running with a node version that doesn't support |
tien
force-pushed
the
refactor/remove-while-loop-from-sm-provider
branch
from
041d84e
to
98874dc
Compare
tien
force-pushed
the
refactor/remove-while-loop-from-sm-provider
branch
from
98874dc
to
6e7e0db
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think this could help with #620?Complete shot in the dark though because I've got that problem only like 3 times so far today.UPDATE: was able to identify the exact problem in #623, I'm leaving this PR open as a potentially good refactor :p