fix: names getting reset when type component unmounted

src/CommonTypes/commonTypes.state.ts

@@ -17,6 +17,7 @@ import {
 } from "rxjs"
 import { selectedChains$ } from "../ChainPicker"
 import { metadatas } from "../api/metadatas"
+import { persistSubscription } from "../lib/persistSubscription"
 
 export type MetadataEntry =
   (V15 | V14)["lookup"] extends Array<infer R> ? R : never
@@ -117,6 +118,8 @@ export const commonTypeNames$ = state(
 
       return result
     }, {}),
+    // Because the list is virtualized, we would lose the state when components unsubscribe
+    persistSubscription(),
   ),
   {},
 )

src/api/metadatas.ts

@@ -7,19 +7,18 @@ import { get, set } from "idb-keyval"
 import { getSmProvider } from "polkadot-api/sm-provider"
 import { mapObject } from "polkadot-api/utils"
 import {
-  ReplaySubject,
   catchError,
   filter,
   finalize,
   map,
   of,
-  share,
   startWith,
   switchMap,
   take,
   tap,
 } from "rxjs"
 import { selectedChains$ } from "../ChainPicker"
+import { persistSubscription } from "../lib/persistSubscription"
 import { chains } from "./smoldot"
 
 export const [changeUseCache$, setUseCache] = createSignal<boolean>()
@@ -58,12 +57,7 @@ export const metadatas = mapObject(chains, (chain$, key) => {
       if (!result) return throughSmoldot$
       return of(result)
     }),
-    share({
-      connector: () => new ReplaySubject(1),
-      resetOnComplete: false,
-      resetOnRefCountZero: false,
-      resetOnError: true,
-    }),
+    persistSubscription(),
   )
 })
 

src/api/smoldot.ts

@@ -1,15 +1,8 @@
 import { startFromWorker } from "polkadot-api/smoldot/from-worker"
 import SmWorker from "polkadot-api/smoldot/worker?worker"
-import {
-  MonoTypeOperatorFunction,
-  Observable,
-  ReplaySubject,
-  combineLatest,
-  defer,
-  share,
-  switchMap,
-} from "rxjs"
+import { Observable, combineLatest, defer, switchMap } from "rxjs"
 import { Chain } from "smoldot"
+import { persistSubscription } from "../lib/persistSubscription"
 
 export const smoldot = startFromWorker(new SmWorker())
 
@@ -48,7 +41,7 @@ export const chains: Record<string, Observable<Chain>> = Object.fromEntries(
           chainSpec,
         }),
       ),
-    ).pipe(persist())
+    ).pipe(persistSubscription())
     const parachainChains = Object.entries(parachains).map(
       ([parachainKey, parachain]) =>
         [
@@ -60,20 +53,11 @@ export const chains: Record<string, Observable<Chain>> = Object.fromEntries(
                 potentialRelayChains: [chainRelayChain],
               }),
             ),
-            persist(),
+            persistSubscription(),
           ),
         ] as const,
     )
 
     return [[key, chainRelayChain], ...parachainChains]
   }),
 )
-
-function persist<T>(): MonoTypeOperatorFunction<T> {
-  return share({
-    connector: () => new ReplaySubject(1),
-    resetOnComplete: false,
-    resetOnRefCountZero: false,
-    resetOnError: true,
-  })
-}

src/lib/persistSubscription.ts

@@ -0,0 +1,10 @@
+import { MonoTypeOperatorFunction, share, ReplaySubject } from "rxjs"
+
+export function persistSubscription<T>(): MonoTypeOperatorFunction<T> {
+  return share({
+    connector: () => new ReplaySubject(1),
+    resetOnComplete: false,
+    resetOnRefCountZero: false,
+    resetOnError: true,
+  })
+}