Skip to content

Commit

Permalink
move flags into main package
Browse files Browse the repository at this point in the history
  • Loading branch information
umanwizard committed Dec 10, 2024
1 parent 6f2a65d commit e6499b2
Show file tree
Hide file tree
Showing 2 changed files with 11 additions and 13 deletions.
2 changes: 1 addition & 1 deletion flags/flags.go → flags.go
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
package flags
package main

import (
"fmt"
Expand Down
22 changes: 10 additions & 12 deletions main.go
Original file line number Diff line number Diff line change
Expand Up @@ -9,10 +9,8 @@ import (
"runtime/debug"
"time"

arrowpb "github.com/open-telemetry/otel-arrow/api/experimental/arrow/v1"
// parcaflags "github.com/parca-dev/parca-agent/flags"
"github.com/oklog/run"
"github.com/polarsignals/gpu-metrics-agent/flags"
arrowpb "github.com/open-telemetry/otel-arrow/api/experimental/arrow/v1"
"github.com/prometheus/client_golang/prometheus"
"github.com/prometheus/client_golang/prometheus/collectors"

Expand Down Expand Up @@ -64,14 +62,14 @@ func fetchBuildInfo() (*buildInfo, error) {
return &buildInfo, nil
}

func mainWithExitCode() flags.ExitCode {
func mainWithExitCode() ExitCode {
ctx := context.Background()

// Fetch build info such as the git revision we are based off
buildInfo, err := fetchBuildInfo()
if err != nil {
fmt.Println("failed to fetch build info: %w", err) //nolint:forbidigo
return flags.ExitFailure
return ExitFailure
}
if commit == "" {
commit = buildInfo.VcsRevision
Expand All @@ -83,15 +81,15 @@ func mainWithExitCode() flags.ExitCode {
goArch = buildInfo.GoArch
}

f, err := flags.Parse()
f, err := Parse()
if err != nil {
slog.Error("Failed to parse flags", "error", err)
return flags.ExitParseError
return ExitParseError
}

if f.Version {
fmt.Printf("parca-agent, version %s (commit: %s, date: %s), arch: %s\n", version, commit, date, goArch) //nolint:forbidigo
return flags.ExitSuccess
return ExitSuccess
}

reg := prometheus.NewRegistry()
Expand All @@ -106,7 +104,7 @@ func mainWithExitCode() flags.ExitCode {
grpcConn, err := f.RemoteStore.WaitGrpcEndpoint(ctx, reg, noop.NewTracerProvider())
if err != nil {
slog.Error("Failed to connect to server", "error", err)
return flags.ExitFailure
return ExitFailure
}
defer grpcConn.Close()

Expand All @@ -116,7 +114,7 @@ func mainWithExitCode() flags.ExitCode {
if f.MetricsProducer.NvidiaGpu {
nvidia, err := NewNvidiaProducer()
if err != nil {
return flags.Failure("Failed to instantiate nvidia metrics producer: %v. Are the Nvidia drivers installed?", err)
return Failure("Failed to instantiate nvidia metrics producer: %v. Are the Nvidia drivers installed?", err)
}
arrowMetricsExporter.AddProducer(ProducerConfig{
Producer: nvidia,
Expand Down Expand Up @@ -147,8 +145,8 @@ func mainWithExitCode() flags.ExitCode {
err = g.Run()
if err != nil {
slog.Error("metrics exporter exited with error", "error", err)
return flags.ExitFailure
return ExitFailure
}

return flags.ExitSuccess
return ExitSuccess
}

0 comments on commit e6499b2

Please sign in to comment.