-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement FromPyObject and IntoPy Traits for AnyValue #37
Open
JabobKrauskopf
wants to merge
11
commits into
pola-rs:main
Choose a base branch
from
JabobKrauskopf:main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
4500d8d
Implement FromPyObject and IntoPy for AnyValue
JabobKrauskopf b77b8b0
Merge branch 'pola-rs:main' into main
JabobKrauskopf 038fe47
#37 Remove println
JabobKrauskopf ea36a64
#37 Fix conversion error and improve number readability
JabobKrauskopf 8dafa58
#37 Improve error handling
JabobKrauskopf 256bc04
#37 Spelling and grammar
JabobKrauskopf 8adcb61
#37 Improve datetime conversion accuracy
JabobKrauskopf a5afc25
#37 Undo part of last commit which decreased conversion accuracy
JabobKrauskopf b61fbde
Merge branch 'pola-rs:main' into main
JabobKrauskopf 1e145e8
Merge remote-tracking branch 'upstream/main'
JabobKrauskopf 6b946ef
refactor: IntoPy and FromPyObject now work the same as in py-polars
JabobKrauskopf File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,34 @@ | ||
use std::cell::UnsafeCell; | ||
|
||
use pyo3::{PyResult, Python}; | ||
|
||
// Adapted from PYO3 with the only change that | ||
// we allow mutable access with when the GIL is held | ||
|
||
pub struct GILOnceCell<T>(UnsafeCell<Option<T>>); | ||
|
||
// T: Send is needed for Sync because the thread which drops the GILOnceCell can be different | ||
// to the thread which fills it. | ||
unsafe impl<T: Send + Sync> Sync for GILOnceCell<T> {} | ||
unsafe impl<T: Send> Send for GILOnceCell<T> {} | ||
|
||
impl<T> GILOnceCell<T> { | ||
/// Create a `GILOnceCell` which does not yet contain a value. | ||
pub const fn new() -> Self { | ||
Self(UnsafeCell::new(None)) | ||
} | ||
|
||
/// as long as we have the GIL we can mutate | ||
/// this creates a context that checks that. | ||
pub fn with_gil<F, O>(&self, _py: Python<'_>, mut op: F) -> PyResult<O> | ||
where | ||
F: FnMut(&mut T) -> PyResult<O>, | ||
{ | ||
// Safe because GIL is held, so no other thread can be writing to this cell concurrently. | ||
let inner = unsafe { &mut *self.0.get() } | ||
.as_mut() | ||
.expect("not yet initialized"); | ||
|
||
op(inner) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This implementation of the
GILOnceCell
can only be used if the users of this library also include a function that is called "on startup", that initializes the value in the Cell, similar to https://github.com/pola-rs/polars/blob/97eff077f37209386836361e9ab4da582bc5b18e/py-polars/src/on_startup.rs#L98I don't think that this requirement would be a good idea. We could check in the
with_gil
function if the value in the cell has been initialized, and if not initialize it there