-
-
Notifications
You must be signed in to change notification settings - Fork 2.4k
refactor: Add new PlPath
that abstracts over URI and PathBuf
#23062
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I am not sure about calling it |
Address
that abstracts over URI and PathBufPlPath
that abstracts over URI and PathBuf
4bf0c35
to
7ae9687
Compare
7ae9687
to
3dca902
Compare
crates/polars-utils/src/plpath.rs
Outdated
self.uri | ||
} | ||
|
||
pub fn offset_path(&self) -> &str { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: maybe call it strip_scheme()
?
Could we directly use |
This would mean you require cloning |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23062 +/- ##
==========================================
- Coverage 80.23% 80.13% -0.11%
==========================================
Files 1684 1685 +1
Lines 223938 224143 +205
Branches 2809 2809
==========================================
- Hits 179677 179614 -63
- Misses 43601 43869 +268
Partials 660 660 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
No description provided.