Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Refactor code for re-use by streaming NDJSON source #21520

Merged
merged 2 commits into from
Mar 1, 2025

Conversation

nameexhaustion
Copy link
Collaborator

@nameexhaustion nameexhaustion commented Feb 28, 2025

Some moving / factoring of functions for the NDJSON source

  • Moves some memory prefetch functions from io_sources/parquet under new streaming to polars-utils

@github-actions github-actions bot added internal An internal refactor or improvement rust Related to Rust Polars labels Feb 28, 2025
@nameexhaustion nameexhaustion changed the title refactor(rust): Refactor code for re-use by streaming NDJSON source refactor: Refactor code for re-use by streaming NDJSON source Feb 28, 2025
@github-actions github-actions bot added the python Related to Python Polars label Feb 28, 2025
@nameexhaustion nameexhaustion force-pushed the ndjson branch 2 times, most recently from 6bf7d0a to fed1463 Compare February 28, 2025 09:25
&row_group_metadata,
columns.as_ref(),
) {
let fetched_bytes =
Copy link
Collaborator Author

@nameexhaustion nameexhaustion Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code in this section isn't changed - I'm not sure why there's a big diff

on local -
image

Copy link

codecov bot commented Feb 28, 2025

Codecov Report

Attention: Patch coverage is 58.01887% with 89 lines in your changes missing coverage. Please review.

Project coverage is 79.81%. Comparing base (69612d4) to head (317b7b1).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
crates/polars-utils/src/mem.rs 49.15% 60 Missing ⚠️
crates/polars-io/src/ndjson/core.rs 61.53% 15 Missing ⚠️
...c/nodes/io_sources/parquet/row_group_data_fetch.rs 64.86% 13 Missing ⚠️
crates/polars-io/src/ndjson/mod.rs 93.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #21520      +/-   ##
==========================================
- Coverage   79.81%   79.81%   -0.01%     
==========================================
  Files        1592     1591       -1     
  Lines      229268   229310      +42     
  Branches     2623     2623              
==========================================
+ Hits       182987   183016      +29     
- Misses      45676    45689      +13     
  Partials      605      605              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nameexhaustion nameexhaustion marked this pull request as ready for review February 28, 2025 17:10
@ritchie46 ritchie46 merged commit 20ee230 into pola-rs:main Mar 1, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
internal An internal refactor or improvement python Related to Python Polars rust Related to Rust Polars
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants