feat: Implement From NaiveDate for AnyValue #21255
Open
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21255 +/- ##
==========================================
- Coverage 79.88% 79.80% -0.09%
==========================================
Files 1593 1596 +3
Lines 227754 228471 +717
Branches 2600 2607 +7
==========================================
+ Hits 181937 182322 +385
- Misses 45220 45553 +333
+ Partials 597 596 -1 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Feb 15, 2025
| @@ -1708,6 +1710,12 @@ impl From<bool> for AnyValue<'static> { | |||
| } | |||
| } | |||
|
|
|||
| impl From<NaiveDate> for AnyValue<'static> { | |||
There was a problem hiding this comment.
Can we actually use this code somewhere in Polars.
If we add it, we should also replace the code where we did this manually.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.