feat: Support any iterator for from_rows_iter_and_schema #21227
+109
−107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IntoIterator<Item = AnyValue>`
eranfu
requested review from
ritchie46,
c-peters,
alexander-beedie,
MarcoGorelli,
reswqa and
orlp
as code owners
eranfu
changed the title
from_rows_iter_and_schema from &Row to `…
github-actions
bot
added
enhancement
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21227 +/- ##
==========================================
- Coverage 79.88% 79.75% -0.13%
==========================================
Files 1593 1594 +1
Lines 227754 228109 +355
Branches 2600 2600
==========================================
- Hits 181937 181930 -7
- Misses 45220 45582 +362
Partials 597 597 ☔ View full report in Codecov by Sentry. |
ritchie46
reviewed
Feb 15, 2025
| @@ -40,65 +40,36 @@ impl DataFrame { | |||
| /// This should only be used when you have row wise data, as this is a lot slower | |||
| /// than creating the [`Series`] in a columnar fashion | |||
| pub fn from_rows_and_schema(rows: &[Row], schema: &Schema) -> PolarsResult<Self> { | |||
| Self::from_rows_iter_and_schema(rows.iter(), schema) | |||
| Self::from_rows_iter_and_schema(rows.iter().cloned(), schema) | |||
There was a problem hiding this comment.
This now clones every row we add? I am for making this more generic, but we should not clone vec buffers for every row.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the item of
from_rows_iter_and_schemafrom&RowtoIntoIterator<Item = AnyValue>Users can make a
DataFramewithout creating theVecorunsafe Row buffer