Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore context.Canceled errors when marking a peer as active #195

Merged
merged 1 commit into from
Feb 9, 2025
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion internal/signaling/timeout_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ package signaling
import (
"context"
"encoding/json"
"errors"
"time"

"github.com/koenbollen/logging"
Expand Down Expand Up @@ -117,7 +118,10 @@ func (manager *TimeoutManager) MarkPeerAsActive(ctx context.Context, peerID stri
logger := logging.GetLogger(ctx)

err := manager.Store.MarkPeerAsActive(ctx, peerID)
if err != nil {

// context.Canceled is expected when the connection is closed right as this function
// is called. We don't want to log this as an error.
if err != nil && !errors.Is(err, context.Canceled) {
logger.Error("failed to mark peer as active", zap.Error(err), zap.String("peer", peerID))
}
}
Expand Down