Remove peer MaxConnectionTime #190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ErikSom
approved these changes
Feb 5, 2025
Caspervw
approved these changes
Feb 5, 2025
koenbollen
reviewed
Feb 5, 2025
There is no need to always disconnect the Websocket connection after an hour. This just causes issues once in a while with db queries being executed at the same time and then being cancelled.
erikdubbelboer
force-pushed
the
rm-MaxConnectionTime
branch
from
94c6cb6 to
20b3d39
Compare
koenbollen
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to always disconnect the Websocket connection after an hour. This just causes issues once in a while with db queries being executed at the same time and then being cancelled.
Edit: it's actually causing issues quite often with
MarkPeerAsActive. This function is scheduled every 30 seconds with a ticker. Because it's a ticker and keeps rhythm perfectly it is always running right after the hour and almost always causes a failed withcontext deadline exceedederror.