Fix double cancellation of Shared.Subscription

pointfreeco · Nov 14, 2024 · f9e82e9 · f9e82e9
1 parent bc4d685
commit f9e82e9
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Sources/ComposableArchitecture/SharedState/PersistenceKey.swift b/Sources/ComposableArchitecture/SharedState/PersistenceKey.swift
@@ -73,7 +73,7 @@ extension Shared {
   /// This object is returned from ``PersistenceReaderKey/subscribe(initialValue:didSet:)``, which
   /// will feed updates from an external system for its lifetime, or till ``cancel()`` is called.
   public class Subscription {
-    let onCancel: () -> Void
+    var onCancel: (() -> Void)?
 
     /// Initializes the subscription with the given cancel closure.
     ///
@@ -88,7 +88,8 @@ extension Shared {
 
     /// Cancels the subscription.
     public func cancel() {
-      self.onCancel()
+      self.onCancel?()
+      self.onCancel = nil
     }
   }
 }