Skip files that don't have enough points to create a neighbourhood #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abelsiqueira
force-pushed
the
108-skip-files-with-not-enough-neighbours
branch
from
1992417
to
6433aa1
Compare
bart1
reviewed
Jun 27, 2023
bird_cloud_gnn/radar_dataset.py
Outdated
| @@ -116,6 +116,11 @@ def _process_data(self, data, origin=""): | |||
| ) | |||
| ].index | |||
| ).reset_index(drop=True) | |||
| if len(data) < self.num_neighbours: | |||
| print( | |||
| f"Warning: There are not enough points to find {self.num_neighbours} neighbourhood" | |||
There was a problem hiding this comment.
Maybe it is worth adding the origin to the message as it makes it easier to identify which file this occurs
|
Should we have a tests of this? |
abelsiqueira
force-pushed
the
108-skip-files-with-not-enough-neighbours
branch
from
6433aa1
to
7e2f87a
Compare
|
Hi @bart1, thanks for the review. I've added the origin and a test. I also rebased. |
abelsiqueira
force-pushed
the
108-skip-files-with-not-enough-neighbours
branch
from
7e2f87a
to
b5ac1e4
Compare
abelsiqueira
force-pushed
the
108-skip-files-with-not-enough-neighbours
branch
from
b5ac1e4
to
c9a621d
Compare
|
Kudos, SonarCloud Quality Gate passed! |
lyashevska
approved these changes
Jul 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the data does not have enough points, skip it.
Related issues:
Closes #108
Instructions to review the pull request
The CI tests are enough