Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] develop from IQSS:develop #643

Open
wants to merge 376 commits into
base: develop
Choose a base branch
from
Open

Conversation

pull[bot]
Copy link

@pull pull bot commented Jul 9, 2024

See Commits and Changes for more details.


Created by pull[bot]

Can you help keep this open source service alive? 💖 Please sponsor : )

poikilotherm and others added 8 commits July 8, 2024 15:19
- The entrypoint now defines two locations, which can be overridden by a user _without_ implicitely trying to execute these scripts.
- The entrypoint now _removes_ any files found at these locations to _always_ start with a clean slate. Otherwise stale files might be looped over and over again.
- A consequence of this: any kind of commands to be included must be provided via a script and cannot be provided by some initial file.
- The configuration scripts no longer leave temporary files dangling and avoid these files if possible. Instead, we are injecting statements into these files while checking for duplicates as a safety measure.
…application

Setting these env vars when reloading are highly application specific and shall not reside in the base image.
- Provide env vars for admin, linux user and domain master password.
- These are set to the publicly known values, good enough for development or demo purposes.
- For production purposes, these variables will be used to change passwords at run/boottime of the container.
- As of this commit, do _not_ leave any password lying around in files, which could be exploited.
A new init script allows to set passwords at boot time of the container. If the passwords are not changed, there will be warnings logged about the default in use.

Slightly modifying the startInForeground.sh script to avoid keeping password files or sensitive passwords around after starting the server.
Added dataverse.db.parameters from long list of JVM options
…e-guestbook-csv-file

adding fix to file name for download guestbook responses
@pull pull bot added the ⤵️ pull label Jul 9, 2024
@coveralls
Copy link

coveralls commented Jul 9, 2024

Pull Request Test Coverage Report for Build #703

Details

  • 305 of 1498 (20.36%) changed or added relevant lines in 78 files are covered.
  • 33 unchanged lines in 20 files lost coverage.
  • Overall coverage increased (+0.1%) to 20.739%

Changes Missing Coverage Covered Lines Changed/Added Lines %
src/main/java/edu/harvard/iq/dataverse/Dataset.java 4 5 80.0%
src/main/java/edu/harvard/iq/dataverse/DatasetServiceBean.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/EjbDataverseEngine.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/GuestbookResponsesPage.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/ManageGuestbooksPage.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/api/AbstractApiBean.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/api/imports/ImportGenericServiceBean.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/authorization/providers/builtin/PasswordEncryption.java 1 2 50.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/DuraCloudSubmitToArchiveCommand.java 0 1 0.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/GoogleCloudSubmitToArchiveCommand.java 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
src/main/java/edu/harvard/iq/dataverse/export/dublincore/DublinCoreExportUtil.java 1 75.7%
src/main/java/edu/harvard/iq/dataverse/DatasetPage.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/pidproviders/doi/XmlMetadataTemplate.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/api/errorhandlers/WebApplicationExceptionHandler.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/AbstractCreateDatasetCommand.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/engine/command/impl/CreateDataverseCommand.java 1 70.59%
src/main/java/edu/harvard/iq/dataverse/api/SavedSearches.java 1 0.0%
src/main/java/edu/harvard/iq/dataverse/DatasetVersionServiceBean.java 1 2.54%
src/main/java/edu/harvard/iq/dataverse/DatasetFieldServiceBean.java 1 15.34%
src/main/java/edu/harvard/iq/dataverse/DatasetServiceBean.java 1 1.86%
Totals Coverage Status
Change from base Build #684: 0.1%
Covered Lines: 17558
Relevant Lines: 84662

💛 - Coveralls

pdurbin and others added 20 commits July 9, 2024 17:04
- better intro
- get issue numbers from snippet filename
- add milestones to issues and PRs
- fix instructions for "target" for tag/release
* Use instanceof to compare types, not class names

* Use instanceof in FileDataProviderFactoryTest

Instead of comparing class names, the tests assert that
`result instanceof Class` (for each appropriate class).
Aligning configbaker and base image with same tool. wait4x has much more features to wait for different services.
As per https://docs.docker.com/reference/dockerfile/#automatic-platform-args-in-the-global-scope BuildKit / buildx will expose the target architecture. It requires adding an ARG in the Dockerfile to inject the data.
jattach binary is now available for ARM64 and AMD64, but requires special handling with download URLs and checksums.
Variable names related to user, password, and domain in Dockerfile and scripts have been modified for better clarity and consistency.

This includes changing the names of admin user and password, domain master password, and Linux password and user.
pdurbin and others added 30 commits September 4, 2024 10:02
…ges-qa

a proposed refinement (simplification) of some of the "main" language names in the new list
* Fixed: MetadataBlockServiceBean to check for not excluded fields in input levels

* Changed: using queries for obtaining dataset field types based on displaying conditions

* Refactor: json printer method for MetadataBlock

* Added: IT test case for list metadata blocks testing field with include=false and displayOnCreate=true property

* Fixed: removed condition in MetadataBlockServiceBean

* Added: release notes for #10741

* Fixed: displayOnCreate query logic

* Fixed: excluding conditionally required fields when display-on-create is true

* Fixed: query predicate for required-in-dataverse field condition

* Fixed: addDataverse API facetIds field json structure

* Added: docs #10800
* Add thumbnail for futured dataverses

* Add documentation

* Release note snippet

* New flyway namming

* Update doc/release-notes/10433-release-notes.md

Co-authored-by: Philip Durbin <[email protected]>

* Release note snippet update
Add new recommandations (HTML preview + "for more information ...")

* Update SQL file name after 6.2 release

* renamed sql file

---------

Co-authored-by: Philip Durbin <[email protected]>
Co-authored-by: Ludovic DANIEL <[email protected]>
Co-authored-by: Philip Durbin <[email protected]>
* remove parentheses

* Correction of the parenthesis display
dataset types (software, workflow, etc.) - initial support
…/dataverse into 10810-search-api-payload-extensions
…S/10824-fix-query-tool-display-on-file-page

IQSS/10824 - Add logic to suppress query tool display for non-public files.
* Remap oai_dc fields dc:type, dc:date, and dc:rights #8129.

The `oai_dc` export and harvesting format has had the following fields remapped:

- dc:type was mapped to the field "Kind of Data". Now it is hard-coded to the word "Dataset".
- dc:date was mapped to the field "Production Date" when available and otherwise to "Publication Date". Now it is mapped only to the field "Publication Date".
- dc:rights was not mapped to anything. Now it is mapped (when available) to terms of use, restrictions, and license.

* add tests for export and citation date #8129

* map dc:date to pub date or field for citation date  #8129

* back out of any changes to dc:rights #8129

* remove OAI-PMH changes from API changelog (also in release note) #8129

* tweak release note, mention backward incompatibility, reexport #8129
…ed) and update URLs (#10535)

* Javascript updates the year automatically and the URLs are customised.

* add taps

* only change year and and all the other errors are still there.
…estFix

IQSS/10840 - DatasetTypesIT test fix
chore(ct): update base image wait4x to 2.14.2 for stdlib update #10844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.