Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added the ability to pass zoomFactor as an option #70

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

joemaffei
Copy link

The project I'm working on required me to pass zoomFactor as an option, but phantom-html-to-pdf defaults it to a 1. This tiny modification is a useful addition to this package, given that different versions of phantomjs reportedly yield PDFs with inconsistent scaling.

Don't mind the whitespace changes! :)

@joemaffei
Copy link
Author

joemaffei commented Jul 13, 2017

I changed one innocent line of code, yet the build is failing miserably.
@pofider Does this prevent the pull request from being accepted?

@pofider
Copy link
Owner

pofider commented Jul 13, 2017

The travis CI just sometimes fails on this package for some reason. Feel free to clone the repo, investigate what we have wrong and send pull request which fix that. :)

I restarted the build and now it is green. So I'm ready to accept it. Just a question before. Does this really allows to run the same html with phantomjs v1 or v2 and the result is the same with just adapting the zoomFactor? I see many issues on phantomjs github which complains the zoomFactor doesn't work. Maybe you could add this to the readme with the particular values which should be set if it really works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants