fix: replace non-functional Pod primitives with standard Solidity in examples#179
Open
namedfarouk wants to merge 1 commit intopodnetwork:mainfrom
Open
fix: replace non-functional Pod primitives with standard Solidity in examples#179namedfarouk wants to merge 1 commit intopodnetwork:mainfrom
namedfarouk wants to merge 1 commit intopodnetwork:mainfrom
Conversation
…examples Resolves podnetwork#129 — requireQuorum, requireTimeBefore, requireTimeAfter, and FastTypes are currently broken on V1 devnet. Updated Tokens, Notary, and Voting examples to use standard Solidity equivalents. Added examples/README.md documenting the workarounds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #129 - SDK examples use Pod-specific primitives (
requireQuorum,requireTimeBefore,requireTimeAfter,FastTypes) that are currently non-functional on V1 devnet (chainId 1293), causing all transactions to revert.Changes
Updated three example contracts to use standard Solidity equivalents:
tokens/contracts/Tokens.sol- replacedrequireQuorum()withrequire()notary/Notary.sol- replacedrequireTimeBefore()andTime.Timestampwithrequire(block.timestamp ...)anduint256solidity/src/Voting.sol- replacedrequireTimeBefore(),requireTimeAfter(),FastTypes.AddressSet,FastTypes.OwnedCounter, andFastTypes.SharedCounterwith standardrequire()checks andmappingtypesAdded
examples/README.mddocumenting the affected primitives, their standard Solidity replacements, and which examples were updated.Notes
requireQuorum()-based primitives on V1 devnet/docscontractsnfts,bsky,hashchallenge,voting) also use affected primitives and can be updated in a follow-up PR