fix(types): prevent panic in confirmation_time on empty attestations#176
Open
giwaov wants to merge 1 commit intopodnetwork:mainfrom
Open
fix(types): prevent panic in confirmation_time on empty attestations#176giwaov wants to merge 1 commit intopodnetwork:mainfrom
giwaov wants to merge 1 commit intopodnetwork:mainfrom
Conversation
`confirmation_time()` indexed into `attestations` using `attestations[len / 2]` without checking whether the slice was empty. When `attestations` is empty this panics with an index-out-of-bounds. Both unit tests in the same file construct `VerifiableLog` with an empty attestations vec, so this is a realistic code path. Change the return type to `Option<Timestamp>` and use `slice::get` so callers can handle the absent case without the process crashing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
VerifiableLog::confirmation_time()indexed into the attestations slice usingattestations[len / 2]without checking whether the slice was empty. Whenattestations.len()is0, this evaluates toattestations[0]and panics with an index-out-of-bounds.Both unit tests in
types/src/ledger/log.rsconstruct aVerifiableLogwith an emptyattestationsvec, so this is a realistic code path — not just a theoretical edge case.Change
Return
Option<Timestamp>instead ofTimestamp, usingslice::getso callers handle the absent case explicitly rather than the process crashing.Test plan
confirmation_time()returnsNonewhen called on aVerifiableLogwith no attestations (as constructed in existing unit tests)confirmation_time()are updated to handleOption<Timestamp>