Skip to content

Conversation

@cdrage
Copy link
Contributor

@cdrage cdrage commented Nov 14, 2025

chore(docs): update the correct url for the dashboard

On clicking, this should actually take you to the readme URL rather than
the 404 page.

What issues does this PR fix or reference?

N/A, found during event.

How to test this PR?

N/A, see markdown.

Signed-off-by: Charlie Drage [email protected]

<!-- If this PR is changing UI, please include
screenshots or screencasts showing the difference -->

On clicking, this should actually take you to the readme URL rather than
the 404 page.

### What issues does this PR fix or reference?

<!-- Include any related issues from Podman Desktop
repository (or from another issue tracker). -->

N/A, found during event.

### How to test this PR?

N/A, see markdown.

<!-- Please explain steps to reproduce -->

Signed-off-by: Charlie Drage <[email protected]>
@cdrage cdrage requested a review from a team as a code owner November 14, 2025 06:37
@cdrage cdrage requested review from feloy, jeffmaury and simonrey1 and removed request for a team November 14, 2025 06:37
Copy link
Contributor

@simonrey1 simonrey1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

codewise LGTM, not tested

let displayDisclaimer = $state(false);
const exampleImage = 'registry.gitlab.com/fedora/bootc/examples/httpd:latest';
const exampleImageReadmeUrl = 'https://gitlab.com/fedora/bootc/examples/-/tree/main/httpd';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I would expect EXAMPLE_IMAGE_README_URL for immutable basic type constants. (but then it's not consistent with the previous constant)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants