Skip to content

Refactor by cfoellmann #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 75 commits into
base: master
Choose a base branch
from
Draft

Refactor by cfoellmann #58

wants to merge 75 commits into from

Conversation

eteubert
Copy link
Member

No description provided.

cfoellmann and others added 30 commits September 2, 2018 15:47
@cfoellmann
bump version to '1.4.0-beta'
a90ff68
@cfoellmann
move all functions into main class to hook into WP
afd9ab0
@cfoellmann
Merge pull request #27 from cfoellmann/no-anonymous
8bc8411 
move anonymous functions hooked into class
@scrutinizer-auto-fixer
Scrutinizer Auto-Fixes
5263e8c 
This commit consists of patches automatically generated for this project on https://scrutinizer-ci.com
@cfoellmann
Merge pull request #38 from podlove/scrutinizer-patch-2
6dee4e3 
Fix Spacing (Scrutinizer Auto-Fixes)
@cfoellmann
fix assets loading
11dd5e1
@cfoellmann
move widget registration to main class
fec2db3
@cfoellmann
rename widget class - we have namespaces so use it
0392a48
@cfoellmann
fix menu item strings for translations
99c1665
@cfoellmann
code style fixes
4f75187
@cfoellmann
add comma to last array items
d005f40
@cfoellmann
debug settings page preview
ff4be00
@cfoellmann
replace spectrum with wpcolorpicker
814cb17
@cfoellmann
fix widget options saving
d13c89f
@cfoellmann
Merge branch 'remove-spectrum'
20f7413
@cfoellmann
move publisher detect function to helpers
fde4346
@cfoellmann
limit translations to language packs
122957a
@cfoellmann
add docblock headers
131d469
@cfoellmann
improve docblocks
bc457c5
@cfoellmann
use core styles for settings display
bdfbd13
@cfoellmann
merge changelog 1.3.x branch
fc808ec
@cfoellmann
check php version without breaking WP
cdb0959
@cfoellmann
Merge pull request #41 from podlove/php-check
eee1236 
check php version without breaking WP
@cfoellmann
remove exclude for spectrum from scrutinizer config
5ac5f32
@cfoellmann
add composer.json
4015791
@cfoellmann
restructuring for psr-4 autoloading
5c586dc
@cfoellmann
commit the autoloader dump for now
53daca9
@cfoellmann
Merge pull request #42 from podlove/autoload
78b81a4 
Autoload
Closes #40
@cfoellmann
move css file to css folder + use core styling for feed table
adda74c
@cfoellmann
move helpers to class
f6f7577
@cfoellmann
add first iteration of setup activate|deactivate|uninstall
41de00c
@cfoellmann
rename filters/actions to prevent clashes with publisher
222fdb5
@cfoellmann
make php detection dependent on PHP 5.2 itself
33ed65c 
Closes #43
@cfoellmann
fix typo in php version requirement
b2c38ce
@cfoellmann
remove constants
b436f6a
@cfoellmann
run migrations from Migration class
692b0e9
@cfoellmann
fix class declaration
ffadbba
@cfoellmann
change defaults option to 1 array
a1c4534
@cfoellmann
fix activation in network scenario
dc0f352
@cfoellmann
Merge branch 'master' into options/array
d1ed183
@cfoellmann
migrate multiple options into one array
06c863a
@cfoellmann
fix php notice - split functions up
b33c285
@cfoellmann
add sitemeta on multisite activation
707b95f
@cfoellmann
register_setting via dedicated class
301a722
@cfoellmann
use settings API to display options fields + fix for network w/o sett…
7000abd 
…ings api features
@cfoellmann
open project links on new tab/window + comment
5c44666
@cfoellmann
rename variable to align with options array key
d19ecf4
@cfoellmann
code style fixes and comments
cdf72d1
@cfoellmann
allow default return value for custom get_option function
7409acd
@cfoellmann
get_option cleanup and comments
523bb07
@cfoellmann
render network preview with site_option config
3d32c22
@cfoellmann
Merge pull request #55 from podlove/options/array
efd7042 
Options/array
@cfoellmann
use network defaults when activating on a subsite
9084d4c
@cfoellmann
remove deactivation hook, add changelog items
261fa32
@cfoellmann
add option to copy shortcode to clipboard - using clipboard.js
bc757f6
@cfoellmann
code styling update
ae9799c
@cfoellmann
Merge pull request #57 from podlove/feature/clipboard-js
d5dc422 
Feature/clipboard js
@cfoellmann
fix issue with copy to clipboard for button names containing spaces
c841144
@eteubert
Copy link
Member Author

Hi @cfoellmann, schon eine Weile her, aber weißt du wie hier der Stand war? Also war das eigentlich fertig und hätte nur released werden müssen, oder gab es hier noch mehr zu tun?

Ich musste das nur gerade von master in einen separaten Branch/PR ziehen, weil ich ein security fix releasen musste und nicht wusste wohin mit deinen commits :)

@cfoellmann
Copy link
Collaborator

Hi,
Danke für die Info.
Ich bin aktuell so gut wie keine Zeit mich drum zu kümmern mich da wieder einzuarbeiten.
Ich bemühe mich. Melde mich hier dann

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@eteubert @cfoellmann @scrutinizer-auto-fixer