Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev #23

Merged
merged 5 commits into from
Jul 1, 2023
Merged

Dev #23

merged 5 commits into from
Jul 1, 2023

Conversation

aodhfionn
Copy link
Member

Got editor set up, currently only applies to text blocks because I think the editing for headers should be more restrictive. Double click a text block to edit, then press the x on the editor toolbar to save.

@aodhfionn aodhfionn requested a review from vimpro June 30, 2023 22:47
@aodhfionn
Copy link
Member Author

@vimpro @YoungerMax

Copy link
Member

@YoungerMax YoungerMax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great

In terms of UX, I think

  • Losing focus/clicking away from the text box should save the content/have the same effect as the x button
  • Only click once to start editing instead of double click
    Later on I think that simply losing focus on the textbox should have the same effect as clicking the x button on the textbox

@vimpro @abdowns What do you guys think about making these changes? If you agree, how quickly do you think they should be added?

@aodhfionn
Copy link
Member Author

Looks great

In terms of UX, I think

* Losing focus/clicking away from the text box should save the content/have the same effect as the x button

* Only click once to start editing instead of double click
  Later on I think that simply losing focus on the textbox should have the same effect as clicking the x button on the textbox

@vimpro @abdowns What do you guys think about making these changes? If you agree, how quickly do you think they should be added?

I agree on the first change, I disagree on the second. I think it would be annoying when simply just looking over a note/scrolling through it and you accidentally click a text box and it brings up the editor. I made it double clicks on purpose because it was a more intentional way to start editing and it reduced the possibility of accidentally opening the editor.

Comment your suggestions here and I'll get to them soon.

@aodhfionn
Copy link
Member Author

@YoungerMax I added the changes you requested

@aodhfionn aodhfionn merged commit a3e20e8 into pocolifo:dev Jul 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants