Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add info about using Corepack with env #448

Merged
merged 2 commits into from
Aug 29, 2023
Merged

Conversation

nachoaldamav
Copy link
Contributor

No description provided.

@stackblitz
Copy link

stackblitz bot commented Aug 23, 2023

Review PR in StackBlitz Codeflow Run & review this pull request in StackBlitz Codeflow.

@vercel
Copy link

vercel bot commented Aug 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
pnpm-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Aug 29, 2023 1:46pm

docs/cli/env.md Outdated
@@ -5,8 +5,13 @@ title: "pnpm env <cmd>"

Manages the Node.js environment.

:::danger
`pnpm env` does not include the binaries for Corepack. If you want to use Corepack to install other package managers, you need to install it separately. See [#4029](https://github.com/pnpm/pnpm/issues/4029)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe instead of the link to the issue just include a link to how install corepack separately. Or the script.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added the installation command, looking at the corepack package.json, it seems that using pnpm to install it is correct (pnpm add -g corepack), but maybe it's better to install it with npm?

@zkochan zkochan merged commit f2a6923 into main Aug 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants