Introduce ShellQuoted to avoid shell quoting issues #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KSXGitHub
requested changes
Nov 29, 2023
KSXGitHub
reviewed
Nov 30, 2023
KSXGitHub
approved these changes
Nov 30, 2023
zkochan
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a shell quoting issue here:
pn/src/main.rs
Line 112 in 9c9654a
Where
pn echo ';ls'would end up runningls.This PR introduces
ShellQuotedthat takes care of quoting, and changes functions that end up callingsh -c ...to use that as parameter, to reduce the chance of reintroducing this kind of issue.Another option is to avoid calling
sh -c ...and instead use https://github.com/denoland/deno_task_shell which will also have the benefit of being more consistent across operating systems.