feat: allow scoped client certificates #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix: use Powershell in windows CI * revert: change step names * fix: set OS PATH in different steps * fix: set Windows PATH * fix: use Powershell v5.1 * fix: specify bvm path manually * fix: dont modify windows PATH * fix: set BVM path in PATH * fix: set user profile automatically
zkochan
reviewed
Jan 18, 2024
Co-authored-by: Zoltan Kochan <[email protected]>
Co-authored-by: Zoltan Kochan <[email protected]>
zkochan
reviewed
Jan 18, 2024
zkochan
reviewed
Jan 31, 2024
zkochan
reviewed
Feb 1, 2024
nachoaldamav
commented
Feb 1, 2024
zkochan
reviewed
Feb 6, 2024
network/config/config.ts
Outdated
| withoutPort: string; | ||
| } | ||
|
|
||
| export function parseUri(uri: string): ParsedUri { |
There was a problem hiding this comment.
I don't see this used anywhere. Should it be exported?
network/config/config.ts
Outdated
Comment on lines
42
to
50
| return { | ||
| raw: parsed.href, | ||
| parsed, | ||
| nerf: nerfDart(uri), | ||
| host: parsed.hostname, | ||
| hostOnlyDomain: convertToDomain(parsed), | ||
| withoutPort: removePort(parsed), | ||
| }; | ||
| } |
There was a problem hiding this comment.
I don't think we need this function because we calculate all these fields but don't always use them, so it is wasting. Like for instance we only used withoutPort after the loop in pickSettingByUrl, so it is enough to call removePort only after the loop
zkochan
approved these changes
Feb 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Todo:
uriToHostfrom another place if possible,@ts-expect-error