Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spfx 1.20 and React Testing Library implement #1459

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Conversation

ervingayle
Copy link
Contributor

By submitting this pull request, you agree to the contribution guidelines

If you aren't familiar with how to contribute to open-source repositories using GitHub, or if you find the instructions on this page confusing, sign up for one of our Sharing is Caring events. It's completely free, and we'll guide you through the process.

Q A
Bug fix? no - yes?
New feature? no - yes?
New sample? no - yes?
Related issues? fixes #1440 , partially #Y, mentioned in #Z

What's in this Pull Request?

Updated SPFx version to 1.20
Migrated to React Testing Library from Enzyme

@Adam-it Adam-it self-assigned this Jan 8, 2025
Copy link
Member

@Adam-it Adam-it left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good 👍
Awesome work 👏👏👏
I checked it locally and added to my tenant. I also added a small fixup in the review process.
You Rock 🤩

samples/react-mega-menu/config/package-solution.json Outdated Show resolved Hide resolved
@ervingayle
Copy link
Contributor Author

Hi @Adam-it . Thanks for the feedback. I will be sure to check for this in the future.

@Adam-it Adam-it merged commit 2d56308 into pnp:main Jan 8, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants