fix(ts-sdk): repair silent credential and fee drops across Hunch, Met… - #2018
Open
AbhilashG12 wants to merge 1 commit into
Open
fix(ts-sdk): repair silent credential and fee drops across Hunch, Met…#2018AbhilashG12 wants to merge 1 commit into
AbhilashG12 wants to merge 1 commit into
Conversation
…aculus, and Hosted routing - Add apiToken to ExchangeOptions and getCredentials() (pmxt-dev#1585) - Add fee forwarding in _hostedBuildOrderBody (pmxt-dev#1648) - Override getCredentials() in Hunch for walletAddress (pmxt-dev#1386) Fixes pmxt-dev#1585 Fixes pmxt-dev#1648 Fixes pmxt-dev#1386
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…aculus, and Hosted routing
buildOrder/createOrdersilently drops the caller-suppliedfeeoverride in TypeScript; Python forwards it #1648)Hunchclass acceptswalletAddressin constructor butgetCredentials()silently drops it — Hunch wallet-gated features always fail #1386)Fixes #1585
Fixes #1648
Fixes #1386