mpichversion: Adding feature string for GPU support for easy detection #7226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checking mpichversion for GPU related feature and library path.
|
test:mpich/ch4/ofi |
hzhou
reviewed
Nov 29, 2024
| with_ze=$(grep 'MPICH configure:' conftest.output | sed -n 's/.*--with-ze=\([^ ]*\).*/\1/p') | ||
| AC_MSG_NOTICE([Detected MPICH with ZE support]) | ||
| fi | ||
|
|
There was a problem hiding this comment.
Will this prevent the testsuite from working with third-party MPI?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR add new feature strings to
mpichversionfor the GPU support. MPICH built with CUDA, HIP or ZE support will show cuda, hip or ze in the MPICH Features ofmpichversion. This allow external tools to easily check for GPU support of the library.This PR also change the configure of MPICH test suite to detect if the MPICH library passed in
--with-mpi=actually have GPU support before checking the availability of corresponding GPU libraries. Previously, the configure of the test suite will check and configure for GPU support even if the MPI does not support GPU (never checked). This leads to failure on sunspot with CPU-only MPICH build. Because ZE library is always present, the test suite will be configured with ZE support while a CPU-only MPICH is provided. The benchmark will failed at runtime due to unable to loadlibze_loader.so.Author Checklist
Particularly focus on why, not what. Reference background, issues, test failures, xfail entries, etc.
Commits are self-contained and do not do two things at once.
Commit message is of the form:
module: short descriptionCommit message explains what's in the commit.
Whitespace checker. Warnings test. Additional tests via comments.
For non-Argonne authors, check contribution agreement.
If necessary, request an explicit comment from your companies PR approval manager.