configure: Restore libuwnind support #401
Merged
+8
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The commit 3196bbf removed the support of libunwind. DAOS-15596 ticket, Update Argobots to 1.2 Signed-off-by: Cedric Koch-Hofer <[email protected]>
|
@yfguo , could it be possible to add you and @shintaro-iwasaki as reviewers of this PR. |
shintaro-iwasaki
approved these changes
Sep 9, 2024
There was a problem hiding this comment.
Thanks, @knard-intel! It seems that I removed it by mistake. It looks good to me!
Please ask @yfguo to merge this PR.
@yfguo , could you please land this PR. |
|
@yfguo , please could you tell me if something is missing to land this PR. |
This was referenced Sep 11, 2024
johannlombardi
approved these changes
Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
The commit 3196bbf removed the support of libunwind.
From the message 3196bbf#r143955103, it seems to not be intentional.
DAOS-15596 ticket, Update Argobots to 1.2
Checklist
module: short descriptionand follows good practice