Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

info: fix ULTs stacks dump works only once #397

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

knard-intel
Copy link

@knard-intel knard-intel commented May 15, 2024

Pull Request Description

Revival of the PR #394 from @bfaccini.

1/one returned value must be tested instead of 0 to detect that last "parked" XStream is done in ABTI_info_check_print_all_thread_stacks() and thus that print_stack_flag can be reset to PRINT_STACK_FLAG_UNSET to allow for a next dump to be started.

DAOS-14248 ticket, Argobots issue #393.

Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers

1/one returned value must be tested instead of 0 to detect that last
"parked" XStream is done in ABTI_info_check_print_all_thread_stacks()
and thus that print_stack_flag can be reset to PRINT_STACK_FLAG_UNSET to
allow for a next dump to be started.

DAOS-14248 ticket, Argobots issue pmodels#393.

Signed-off-by: Cedric Koch-Hofer <[email protected]>
Co-authored-by: Bruno Faccini <[email protected]>
@knard-intel knard-intel marked this pull request as ready for review May 15, 2024 15:37
@knard-intel
Copy link
Author

@yfguo , I am a new member of the DAOS team and I am going to handle some old tasks of @bfaccini .
I am not able, to add reviewers to this PR.
Could it be possible to add relevant reviewers to this PR.
Do not hesitate to tell me if I have miss something in the landing process of the argobots project.

Thanks in advance,
Cedric.

@yfguo yfguo self-requested a review June 17, 2024 20:20
@yfguo yfguo merged commit 5cfab46 into pmodels:main Jun 17, 2024
2 checks passed
@knard-intel knard-intel deleted the ckochhof/master/isue-393 branch June 18, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants