Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

self: suppress warning message of ABT_self_get_type #343

Merged
merged 1 commit into from
Jul 6, 2021

Conversation

shintaro-iwasaki
Copy link
Collaborator

Pull Request Description

This PR fixes #341. Specifically, this PR suppresses a warning message when ABT_self_get_type() (Argobots 1.x) is called on an external thread. This warning message was printed when --enable-debug=err (included by most or all) is set.

(Note that ABT_initialized(), ABT_mutex_trylock(), and ABT_cond_timedwait() also legally return an error like ABT_self_get_type(). They do not print a warning message.)

Checklist

  • Reference appropriate issues (with "Fixes" or "See" as appropriate)
  • Commits are self-contained and do not do two things at once
  • Commit message is of the form: module: short description and follows good practice
  • Passes whitespace checkers

When --enable-debug=err is set, a warning message is printed if an
external thread calls ABT_self_get_type() (Argobots 1.x) while this is
not illegal.  This patch suppresses this message.
@shintaro-iwasaki
Copy link
Collaborator Author

test:argobots/all

@shintaro-iwasaki shintaro-iwasaki merged commit 3abebec into pmodels:main Jul 6, 2021
@shintaro-iwasaki shintaro-iwasaki deleted the pr/fix_341 branch July 29, 2021 18:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ABT_self_get_type() printing on type == ABT_UNIT_TYPE_EXT
1 participant