Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[charts/metabase] fix label indentation in pdb #143

Merged
merged 2 commits into from
Dec 20, 2024

Conversation

tessig
Copy link
Contributor

@tessig tessig commented Dec 18, 2024

deploymentLabels should be intended exactly like pod labels.

If I understood correctly, Values should look like this:

  deploymentLabels:
    app-group: "metabase"
    app.kubernetes.io/name: "metabase"
    foo: bar

With the current template this results in an invalid pdb file

Copy link
Owner

@pmint93 pmint93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, thanks for the fix

@pmint93 pmint93 merged commit 57ed68d into pmint93:master Dec 20, 2024
1 check passed
@tessig tessig deleted the fix/pdb branch January 6, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants