Skip to content

Commit

Permalink
Merge pull request #18 from pluswerk/php8.3-rc
Browse files Browse the repository at this point in the history
  • Loading branch information
Kanti authored Nov 3, 2023
2 parents f801d77 + df12d3b commit b09e8f6
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 8 deletions.
9 changes: 4 additions & 5 deletions .github/workflows/run-grumphp-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -6,12 +6,11 @@ jobs:
strategy:
fail-fast: false
matrix:
php:
- '8.1'
- '8.2'
php: ['8.1', '8.2', '8.3-rc']
container:
image: kanti/buildy:${{ matrix.php }}
steps:
- uses: actions/checkout@v2
- run: COMPOSER_ROOT_VERSION=dev-main composer install --no-progress --no-scripts -n
- uses: actions/checkout@v4
- run: git config --global --add safe.directory /__w/grumphp-bom-task/grumphp-bom-task
- run: COMPOSER_ROOT_VERSION=dev-main composer install --no-progress --no-scripts -n --ignore-platform-req=php+
- run: ./vendor/bin/grumphp run
4 changes: 2 additions & 2 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@
"issues": "https://github.com/pluswerk/grumphp-bom-task/issues"
},
"require": {
"php": "~8.1.0 || ~8.2.0",
"php": "~8.1.0 || ~8.2.0 || ~8.3.0",
"phpro/grumphp": "^2.0.0"
},
"require-dev": {
Expand All @@ -30,9 +30,9 @@
],
"config": {
"allow-plugins": {
"ergebnis/composer-normalize": true,
"phpro/grumphp": true,
"phpstan/extension-installer": true,
"ergebnis/composer-normalize": true,
"pluswerk/grumphp-config": true
}
},
Expand Down
2 changes: 1 addition & 1 deletion src/BomFixerTask.php
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ private function isFileWithBOM(string $filename): bool
private function fileInfoSearch(string $filename, string $search): bool
{
$output = [];
exec('file ' . '"' . $filename . '"', $output, $returnVar);
exec('file "' . $filename . '"', $output, $returnVar);
if ($returnVar !== 0) {
return false;
}
Expand Down

0 comments on commit b09e8f6

Please sign in to comment.