Skip to content

Commit

Permalink
Merge pull request #15 from pluswerk/feature/grumphp-update
Browse files Browse the repository at this point in the history
⬆️ update to be compatible with grumphp to 1.3 but php only >=7.3
  • Loading branch information
Kanti committed May 13, 2021
2 parents 75d2c30 + 8572e11 commit 5c16664
Show file tree
Hide file tree
Showing 3 changed files with 10 additions and 10 deletions.
9 changes: 4 additions & 5 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,14 +1,13 @@
language: php
dist: trusty
sudo: false

git:
depth: 5

php:
- 7.2
- 7.3
- 7.4
- 8.0
- nightly

env:
Expand All @@ -29,9 +28,9 @@ before_install:
- phpenv config-rm xdebug.ini || echo "xdebug not available"

install:
- if [ -z "$dependencies" ]; then composer install --no-progress --no-scripts --no-suggest -n; fi;
- if [ "$dependencies" = "lowest" ]; then composer update --no-progress --no-scripts --no-suggest -n --prefer-lowest; fi;
- if [ "$dependencies" = "highest" ]; then composer require phpro/grumphp:* --no-progress --no-scripts --no-suggest -n; fi;
- if [ -z "$dependencies" ]; then composer install --no-progress --no-scripts -n; fi;
- if [ "$dependencies" = "lowest" ]; then composer update --no-progress --no-scripts -n --prefer-lowest; fi;
- if [ "$dependencies" = "highest" ]; then composer require phpro/grumphp:* --no-progress --no-scripts -n; fi;

script:
- ./vendor/bin/grumphp run
7 changes: 4 additions & 3 deletions composer.json
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@
],
"config": {
"platform": {
"php": "7.2"
"php": "7.3"
}
},
"support": {
Expand All @@ -25,8 +25,9 @@
}
},
"require": {
"php": ">=7.2",
"phpro/grumphp": "0.19.*"
"php": ">=7.3",
"phpro/grumphp": "^1.3.3",
"opis/closure": "^3.6.2"
},
"require-dev": {
"squizlabs/php_codesniffer": ">=3.5.0 <4.0.0"
Expand Down
4 changes: 2 additions & 2 deletions src/ExtensionLoader.php
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@

class ExtensionLoader implements ExtensionInterface
{
public function load(ContainerBuilder $container)
public function load(ContainerBuilder $container): void
{
return $container->register('task.plus_bom_fixer', BomFixerTask::class)
$container->register('task.plus_bom_fixer', BomFixerTask::class)
->addArgument(new Reference('process_builder'))
->addArgument(new Reference('formatter.raw_process'))
->addTag('grumphp.task', ['task' => 'plus_bom_fixer']);
Expand Down

0 comments on commit 5c16664

Please sign in to comment.