Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Robot Base class mutex #80

Open
mlautman opened this issue Apr 23, 2019 · 1 comment
Open

Robot Base class mutex #80

mlautman opened this issue Apr 23, 2019 · 1 comment

Comments

@mlautman
Copy link
Contributor

I am working to split the trajectory functionality out of the robot class and into it's own class. I noticed that the mutex strategy currently blocks this as the same mutex is used for the Robot functionality as is used by the Trajectory construction and planning.

I am not sure I understand the mutex strategy here.

  1. Why does Robot, (a class that doesn't have any subscriptions) need a mutex?
  2. Why doesn't the online robot class (which does have subscriptions) not use a mutex.

This seems like something we could address rather quickly but I wanted to check to see if I was missing anything before I invested time in a resolution

@mlautman mlautman changed the title Robot Base class Robot Base class mutex Apr 24, 2019
@shaun-edwards
Copy link
Collaborator

Why does Robot, (a class that doesn't have any subscriptions) need a mutex?

This is probably an artifact from when when Robot and Online Robot were the same class.

Why doesn't the online robot class (which does have subscriptions) not use a mutex.

Again probably an oversight. Does Online Robot require/assume a multi-threaded ROS spinner?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants