Skip to content

Wi-Fi Association Bug Fix for BCM #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Wi-Fi Association Bug Fix for BCM #2

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/lib/bcmwl/src/bcmwl_vap.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -537,7 +537,12 @@ void bcmwl_vap_prealloc_all(void)
bssmax = bcmwl_radio_max_vifs(p->d_name);
if (bssmax > BCMWL_VAP_PREALLOC_MAX)
bssmax = BCMWL_VAP_PREALLOC_MAX;
bcmwl_vap_prealloc(p->d_name, bssmax - 1, bcmwl_vap_mac_xfrm);
if(bssmax > 8){
bcmwl_vap_prealloc(p->d_name, bssmax - 1, bcmwl_vap_mac_xfrm);
}else{
//Adding a log here would be helpful to inform the developer/integrator
bcmwl_vap_prealloc(p->d_name, bssmax - 2, bcmwl_vap_mac_xfrm);
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Formatting does not match the existing style. This needs to be fixed.
  2. bssmax will never be greater than 8 by default - the BCMWL_VAP_PREALLOC_MAX is already 8, and will limit bssmax to be 8 at most. Are you building opensync with modified BCMWL_VAP_PREALLOC_MAX? If so, to what value, and why?
  3. Why are you checking bssmax against 8 in particular? Why not 7 or 9?
  4. Why are you decrementing 1 or 2 depending on the condition result? How is this helping, and why is this helping with "Wi-Fi Association Bug".
  5. What is the bug that you're really fixing? Can you describe what you do, and what you see, and what you expect?

}
}

Expand Down