remove APC support #304
Open
remove APC support #304
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
force-pushed
the
remove/apc
branch
4 times, most recently
from
575dff6
to
3253b8f
Compare
APC is only supported up to PHP 5.5. As Cachify now requires PHP 5.6 or later, there is no point in maintaining legacy APC support. We already ignore unavailable backends silently with fallback to DB, so just removing it does not make it worse here.
stklcode
added a commit
that referenced
this pull request
Aug 6, 2024
APC is only supported up to PHP 5.5. As Cachify now requires PHP 5.6 or later, there is no point in maintaining legacy APC support. We already ignore unavailable backends silently with fallback to DB, so just removing it does not make it worse here.
We should not silently ignore misconfiguration and fall back to DB caching. We now check for availability and disable caching via a "no operation" backend. We can also add a notice for APC now which is no longer supported.
stklcode
force-pushed
the
remove/apc
branch
2 times, most recently
from
f45e3f9
to
70a629d
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
APC is only supported up to PHP 5.5. As Cachify now requires PHP 5.6 or later, there is no point in maintaining legacy APC support.
We also introduce an admin notice, if the configured backend is not available. This applies to all backends except DB.