-
-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent unnecessary cache clearing #224
Conversation
because of edit_comment https://developer.wordpress.org/reference/hooks/edit_comment/
because of edit_comment https://developer.wordpress.org/reference/hooks/edit_comment/
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your work.
The changes in general are well suited for point release like 2.4, however they do introduce some breaking changes and I'm not sure whether we should raise the major version for this, if there is an viable way to add the new behavior non-breaking.
inc/class-cachify.php
Outdated
'user_register' => 10, | ||
'edit_user_profile_update' => 10, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would not remove those, like @stklcode wrote in #223 (comment), user info can be displayed in many places.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-added "edit_user_profile_update" for now in decdd88
We can discuss about refining this in future changes.
We require 4.7 since #268, so that's no longer an issue here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be OK now.
A second opinion would not hurt here though.
Quality Gate passedIssues Measures |
flush cache when comment is in database and not before
flush when comment is or was approved
move comment hooks to comment 'flush hooks'
rename functions for better code comprehension
removes user_register and edit_user_profile_update from flush total cache
because of edit_comment $data we need wp 4.6 or greater
#223