Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escaping and better .htaccess hdd sample code #208

Closed
wants to merge 9 commits into from

Conversation

timse201
Copy link
Contributor

@timse201 timse201 commented Mar 26, 2021

closes #157

@timse201 timse201 changed the title Escaping and #200 Escaping and better .htaccess hdd sample code Apr 15, 2021
@florianbrinkmann
Copy link
Member

Hi @timse201, I tried to verify that the changes fix the issue with the cached post request, but I still get the cached version for post requests with the changed .htaccess. Could you tell me the steps how I can test that? Thanks!

@florianbrinkmann
Copy link
Member

The PR does not fix #200, I will open a PR for that later today. I am not sure about the other changes, is escaping needed here, does that have any advantages over leaving the .htaccess example as it is?

@pluginkollektiv pluginkollektiv deleted a comment from sonarcloud bot Oct 31, 2023
Copy link

sonarcloud bot commented Mar 29, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
2.9% Duplication on New Code

See analysis details on SonarCloud

@pluginkollektiv pluginkollektiv deleted a comment from sonarcloud bot Jun 30, 2024
RewriteCond %{REQUEST_URI} !^/(wp-admin|wp-content/cache)/.*
RewriteCond %{HTTP_COOKIE} !(wp-postpass|wordpress_logged_in|comment_author)_
RewriteCond %{QUERY_STRING} ^$
RewriteCond %{REQUEST_URI} !^\/(wp\-admin|wp\-content\/cache)\/.*
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there any reason to escape the characters here?

/ is not used as a delimiter in this context and - is no reserved character outside character groups 🤔

@stklcode
Copy link
Contributor

stklcode commented Aug 4, 2024

Closing this PR in favor of #302 and other refactoring around that area. Real issues should be all resolved by now. Feel free to reopen this in case we missed something.

@stklcode stklcode closed this Aug 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hdd.htaccess
3 participants