-
-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Escaping and better .htaccess hdd sample code #208
Conversation
Hi @timse201, I tried to verify that the changes fix the issue with the cached post request, but I still get the cached version for post requests with the changed |
The PR does not fix #200, I will open a PR for that later today. I am not sure about the other changes, is escaping needed here, does that have any advantages over leaving the |
|
RewriteCond %{REQUEST_URI} !^/(wp-admin|wp-content/cache)/.* | ||
RewriteCond %{HTTP_COOKIE} !(wp-postpass|wordpress_logged_in|comment_author)_ | ||
RewriteCond %{QUERY_STRING} ^$ | ||
RewriteCond %{REQUEST_URI} !^\/(wp\-admin|wp\-content\/cache)\/.* |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is there any reason to escape the characters here?
/
is not used as a delimiter in this context and -
is no reserved character outside character groups 🤔
Closing this PR in favor of #302 and other refactoring around that area. Real issues should be all resolved by now. Feel free to reopen this in case we missed something. |
closes #157