Allow change of debug log directory #595
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stklcode
reviewed
May 22, 2024
| $content_dir = \WP_CONTENT_DIR; | ||
| $date = date( 'Y-m-d' ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date | ||
| $time = date( 'H-i-s' ); // phpcs:ignore WordPress.DateTime.RestrictedFunctions.date_date | ||
| $log_dir = defined( 'ANTISPAM_BEE_DEBUG_MODE_LOG_DIR' ) ? \ANTISPAM_BEE_DEBUG_MODE_LOG_DIR : \WP_CONTENT_DIR; |
There was a problem hiding this comment.
Pretty long const name, would have preferred something a little shorter, e.g. strip the _MODE. But we should probably keep it consistent with ANTISPAM_BEE_DEBUG_MODE_ENABLED, so I'm fine with either.
There was a problem hiding this comment.
True, it’s a little long 😬 Because we are not live yet and only two or three people might be using it, I would say let’s change the ANTISPAM_BEE_DEBUG_MODE_ENABLED to ANTISPAM_BEE_DEBUG and the log to ANTISPAM_BEE_DEBUG_DIR?
stklcode
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.