Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show upgrade_notice also on plugin overview page #516

Merged
merged 7 commits into from
Jul 26, 2023

Conversation

pfefferle
Copy link
Member

No description provided.

@pfefferle
Copy link
Member Author

fixes #498

antispam_bee.php Outdated Show resolved Hide resolved
@florianbrinkmann
Copy link
Member

LGTM. PHPCS is complaining

@pfefferle
Copy link
Member Author

Yes, I think it's the autop! Should I remove it?

@florianbrinkmann
Copy link
Member

Yes, I think it's the autop! Should I remove it?

Not sure, what do you mean @Zodiac1978 @2ndkauboy @krafit?

I think it would be great to be able to add links to the text, f.e. to a page with more details on pluginkollektiv.org, so maybe not strip all HTML but allow at least links.

@pfefferle
Copy link
Member Author

Ok, will change it to use kses instead

@Zodiac1978
Copy link
Member

It looks like a false positive, because the content is escaped, or not?
wpautop( esc_html( $data['upgrade_notice '] ) )

Sonarcloud is also complaining about the superflous parameter:
Remove the unused function parameter "$response".

The other one could be ignored, because there are no better, native ways. Correct?
Change this code to not construct SQL queries directly from user-controlled data.

@sonarcloud
Copy link

sonarcloud bot commented Jul 24, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability E 1 Vulnerability
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

Copy link
Member

@florianbrinkmann florianbrinkmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfefferle pfefferle merged commit a4ba7ac into master Jul 26, 2023
20 of 21 checks passed
@pfefferle pfefferle deleted the add/upgrade_notice branch July 26, 2023 06:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants