-
-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
show upgrade_notice
also on plugin overview page
#516
Conversation
fixes #498 |
LGTM. PHPCS is complaining |
Yes, I think it's the autop! Should I remove it? |
Not sure, what do you mean @Zodiac1978 @2ndkauboy @krafit? I think it would be great to be able to add links to the text, f.e. to a page with more details on pluginkollektiv.org, so maybe not strip all HTML but allow at least links. |
Ok, will change it to use kses instead |
It looks like a false positive, because the content is escaped, or not? Sonarcloud is also complaining about the superflous parameter: The other one could be ignored, because there are no better, native ways. Correct? |
SonarCloud Quality Gate failed. 0 Bugs No Coverage information Catch issues before they fail your Quality Gate with our IDE extension SonarLint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.