migrate dashboard chart from Raphael to Chartist (#406) #483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the same chart library and UI as it is used in Statify now. Doing so, we migrate the graphics library from Raphaël to Chartist with a tooltips plugin and adjust the wrapper script and styling accordingly. Including CSS and tooltips plugin, Chartist is about 50KB of size compared to 96KB for Raphaël.
stklcode
force-pushed
the
feature/406-chartist
branch
from
7252442
to
06c17a4
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the same chart library and UI as it is used in Statify now. Doing so, we migrate the graphics library from Raphaël to Chartist with a tooltips plugin and adjust the wrapper script and styling accordingly.
Including CSS and tooltips plugin, Chartist is about 50KB of size compared to 96KB for Raphaël.
No further improvements for now, just copy the generation script and styles from the Statify project and add the external libs as fixed files as it was done with the old library.
Preview:
When merged, this PR resolves #406.