squashfs support for uuid and label #264
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's working code for #59, the basics of which I've reimplemented a few times over the years.
Curious what @plougher thinks about this approach.
Due to the way squashfs directly stores the offsets to the datablocks and fragments, and the remaining sections having offsets stored in the superblock... no squashfs-mount/unsquashfs/etc implementation I've encountered ever expects or needs the datablocks to start at the next byte after the (optional) compression options metablock.
As such, it has proved to be perfectly backwards compatible wherever I've used it.
See #59 (comment) for how it is used, behaves, and how to build it (and the corresponding changes to libblkid)
Let me know if this approach (or something similar) has a chance of being merged upstream.
Only after the above question is answered... here are some preemptive comments for other things to think about before considering merging: