add lodash to nivo/line's package.json #2608
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@jonaengs, the lock file needs to be updated accordingly, most jobs are failing due to this. |
|
Hey @plouc thanks for the tip. I'm not super experienced with javascript development, so all input is appreciated:) I think I've updated the lockfile correctly, but I see that the workflows are still failing, so maybe I missed something? I've allowed edits by maintainers for the PR, so if you spot my mistake and want to quickly fix it yourself, feel free. Otherwise I'll do my best to fix the issues myself. Though I might need some more pointers before I'm able to make meaningful progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
nivo/packages/line/src/hooks.js
Line 6 in da6d6b7
nivo/lineimportsuniqueIdfrom lodash in the hooks.js file. However, lodash is not declared as a dependency innivo/line's package.json file. This was causing my project to crash when using the package with pnpm.The PR fixes the issue by adding lodash as a dependency